Skip to content
This repository was archived by the owner on Jan 12, 2026. It is now read-only.

Port to MC1.19.3#96

Open
lonefelidae16 wants to merge 1 commit into
stashymane:1.19.3from
lonefelidae16:port/1.19.3
Open

Port to MC1.19.3#96
lonefelidae16 wants to merge 1 commit into
stashymane:1.19.3from
lonefelidae16:port/1.19.3

Conversation

@lonefelidae16
Copy link
Copy Markdown

awaiting for a new release of SoundCategories...


Changes

  • update dependencies

    • gradle.properties
      • yarn mappings 1.19.3+build.5
      • fabric api 0.71.0
      • fabric loader 0.14.12
      • ARRP 0.6.7
    • build.gradle
      • fabric loom 1.0-SNAPSHOT
    • gradle-wrapper.properties
      • Gradle 7.6
  • class usage has changed

    • new SoundEvent -> SoundEvent.of
  • mixin method signature has changed

    • affected classes: inventory.InventoryClickSounds, inventory.CreativeScreenHandlerSounds
      • net.minecraft.screen.ScreenHandler#transferSlot -> quickMove
    • affected class: EffectMixin
      • ClientPlayerEntity#<init>(ClientWorld, GameProfile, PlayerPublicKey) -> <init>(ClientWorld, GameProfile)
  • mixin field type has changed

    • affected class: inventory.CreativeInventoryClickSounds
      • net.minecraft.client.gui.screen.ingame.CreativeInventoryScreen::selectedTab: int -> ItemGroup
  • import statement has changed

    • javax.annotation.* -> org.jetbrains.annotations.*
    • net.minecraft.util.registry.Registry -> net.minecraft.registry.*

* update dependencies
  - `gradle.properties`
    + yarn mappings 1.19.3+build.5
    + fabric api 0.71.0
    + fabric loader 0.14.12
    + ARRP 0.6.7
  - `build.gradle`
    + fabric loom 1.0-SNAPSHOT
  - `gradle-wrapper.properties`
    + Gradle 7.6

* class usage has changed
  - `new SoundEvent` -> `SoundEvent.of`

* mixin method signature has changed
  - affected classes: `inventory.InventoryClickSounds`, `inventory.CreativeScreenHandlerSounds`
    + `net.minecraft.screen.ScreenHandler#transferSlot` -> `quickMove`
  - affected class: `EffectMixin`
    + `ClientPlayerEntity#<init>(ClientWorld, GameProfile, PlayerPublicKey)` -> `<init>(ClientWorld, GameProfile)`

* mixin field type has changed
  - affected class: `inventory.CreativeInventoryClickSounds`
    + `net.minecraft.client.gui.screen.ingame.CreativeInventoryScreen::selectedTab`: `int` -> `ItemGroup`

* import statement has changed
  - `javax.annotation.*` -> `org.jetbrains.annotations.*`
  - `net.minecraft.util.registry.Registry` -> `net.minecraft.registry.*`
@stashymane stashymane changed the base branch from main to 1.19.3 January 14, 2023 14:41
@stashymane
Copy link
Copy Markdown
Owner

Will release new SoundCategories version tomorrow after testing, i'll bump the version myself, thanks :)

@lonefelidae16 lonefelidae16 marked this pull request as ready for review January 21, 2023 02:20
@lonefelidae16
Copy link
Copy Markdown
Author

i'll bump the version myself

Sorry for my misunderstanding, but I thought I needed to wait for a new version of SoundCategories, write the gradle.properties myself, then create a new commit and mark this PR as ready. But reading your comment again, I don’t think that is necessary.

I have now marked this PR as ready, my bad.

@Vi-Tul
Copy link
Copy Markdown

Vi-Tul commented Mar 9, 2023

Any updates?

@lonefelidae16
Copy link
Copy Markdown
Author

yeah 1.19.4 stable is out but I still can’t find the new SoundCategories release, perhaps I was quite an idiot for seriously creating this pull, haha.

As you can see, I’m impatient and can’t wait for official releases, so I have “UNOFFICIAL” ports of ExtraSounds and SoundCategories for my use. The code is available on my fork, and you can get the pre-built jars on my maven.

I know my decision may seem foolish and unwelcome to some. For now, modification and redistribution seem to be no problem, but if the license (of course including these libraries) or the owner reject this, I may stop publishing them.

@zndrmn
Copy link
Copy Markdown

zndrmn commented Mar 15, 2023

How can I compile this myself? not sure how to get sound categories to work with extra sounds
its complaining about sound categories mixins and failing

nvm figured it out kinda

@lonefelidae16
Copy link
Copy Markdown
Author

lonefelidae16 commented Mar 15, 2023

Ah, I wrote it in #92 , but the content is out of date. That’s referring to branches that no longer exist... I would like to rewrite it anew in my Wiki.
Update: seems no problem... but not completed. I’ll update as needed. https://github.com/lonefelidae16/extra-sounds/wiki

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants